Repository navigation
Fix broken async partitioner integration tests - #193
Conversation
移除 asyncio 标记并同步调用存储与分区接口。 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Friendly ping for review when you have a moment 🙂 The three-way split from #192 is ready and stable:
CI note: the earlier |
ChenZiHong-Gavin
left a comment
There was a problem hiding this comment.
LGTM. Pure test-side change: the partitioner/storage APIs are synchronous on main, the NetworkXStorage import now points at graphgen.storage, and the list() wrapping is correct for the generator-returning partitioners. Pylint CI is green on 3.10/3.11/3.12.
…ce#195 + 维护者评审修复) Co-Authored-By: Claude Code <noreply@anthropic.com>
…nce#195 + 维护者评审修复) 冲突解决策略: - 上游评审版为主:分区器默认翻转、构建器重构、profile loader、 抽取器与 8 个生成器的签名/格式修复 - fork 生产特性保留:support 出处接线(生成器+服务+透传)、 三个 PMS 出题门、中文事件描述模板、max_communities loss 选题、 reload 有界重试、思考模型空响应容错(PMS_PATCHES InternScience#11)、 pms 身份与 event_profiles 资源 Co-Authored-By: Claude Code <noreply@anthropic.com>
|
Thanks for reviewing and merging, @ChenZiHong-Gavin! Glad this helps keep the partitioner integration tests healthy on main. It felt good to hand over tests that run green against upstream APIs — thanks for making that easy. |
Summary
@pytest.mark.asynciocoroutine calls to synchronous calls matching the current synchronousBasePartitioner/storage APIs.from graphgen.models import NetworkXStorageimport (storage lives ingraphgen.storage); these tests fail to even collect onmaintoday.This is the first of three PRs split from #192 per review feedback (smallest first). PR B (prompt profiles/gates/concurrency/LLM patches) and PR C (event-entity pipeline) follow separately.
Validation
pytest tests/integration_tests/models/partitioner/→ 12 passed.🤖 Generated with Claude Code