Skip to content

Apply the small hardening fixes from the security audit - #99

Merged
jaredwray merged 5 commits into
mainfrom
cursor/cheap-hardening-1d54
Nov 8, 2026
Merged

jaredwray merged 5 commits into
mainfrom
cursor/cheap-hardening-1d54

Conversation

@jaredwray

@jaredwray jaredwray commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • Followed the Contributing guidelines and Code of Conduct
  • Tests for the changes have been added (for bug fixes/features) with 100% code coverage.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Configuration fix and docs update.

Summary

Biome includes now cover .tsx files in src and test.
The clean script keeps pnpm-lock.yaml.
SECURITY.md and DEFENSE_IN_DEPTH.md match pnpm@12.17.0 and the release scan.
The three workflows do not set HYPHEN_PUBLIC_API_KEY or HYPHEN_APPLICATION_ID.
The .tsx files now pass biome check --error-on-warnings.

Test audit

This pull request does not add a test.
This pull request does not delete a test.
test/toggle-provider.test.tsx, test/use-toggle.test.tsx, and test/with-toggle-provider.test.tsx changed so Biome can check them.
The assertions stay the same.
The components now live at module scope.
noComponentHookFactories rejects a component inside a test function.
No new export is required.

Checks

Biome 2.6.4 check --write --error-on-warnings exited 0.
Python parsed biome.json and package.json.
Python parsed tests.yaml, code-coverage.yaml, and release.yaml.
Local pnpm install did not finish. The Safe Chain tunnel refused connections.
This environment has no Aikido scan server.
Run /aikido:setup before you rely on a scan of these files.

Open in Web Open in Cursor 

cursoragent and others added 4 commits November 8, 2026 17:55
The old globs match only .ts files. Biome did not check the .tsx source files.

Co-authored-by: Jared Wray <me@jaredwray.com>
pnpm-lock.yaml is a tracked file. CI installs with --frozen-lockfile. The clean script must keep the lockfile.

Co-authored-by: Jared Wray <me@jaredwray.com>
The pnpm pin matches package.json. The documents name the release workflow as the Aikido scan. The zizmor job grants security-events: write.

Co-authored-by: Jared Wray <me@jaredwray.com>
The workflows set HYPHEN_PUBLIC_API_KEY and HYPHEN_APPLICATION_ID. Source files do not read those variables. Tests use literal values.

Co-authored-by: Jared Wray <me@jaredwray.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-08T17:56:56.619338Z 905df7f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the security and configuration documentation, expands the Biome linter configuration, and refactors the package cleanup script. Specifically, DEFENSE_IN_DEPTH.md and SECURITY.md are updated to reflect the pinning of pnpm@12.17.0, clarify that Aikido scans run only on release workflows rather than pull requests, and document that the zizmor job grants security-events: write permissions. Additionally, biome.json is updated to include .tsx files in src and test directories, and the clean script in package.json is modified to prevent the deletion of pnpm-lock.yaml. There are no review comments to address, and no further feedback is provided.

Sort the imports in the .tsx files. Put the Biome includes list on one line. Remove the unused effect dependency. Use an arrow function for the generic wrapper. Move test components to module scope.

Co-authored-by: Jared Wray <me@jaredwray.com>
@codecov

codecov Bot commented Nov 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2cdb214) to head (85f19e5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #99   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           19        18    -1     
  Branches         1         1           
=========================================
- Hits            19        18    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit b49637e into main Nov 8, 2026
12 checks passed
@jaredwray
jaredwray deleted the cursor/cheap-hardening-1d54 branch November 8, 2026 18:11
@jaredwray jaredwray mentioned this pull request Nov 8, 2026
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants