Repository navigation
Apply the small hardening fixes from the security audit - #99
Conversation
The old globs match only .ts files. Biome did not check the .tsx source files. Co-authored-by: Jared Wray <me@jaredwray.com>
pnpm-lock.yaml is a tracked file. CI installs with --frozen-lockfile. The clean script must keep the lockfile. Co-authored-by: Jared Wray <me@jaredwray.com>
The pnpm pin matches package.json. The documents name the release workflow as the Aikido scan. The zizmor job grants security-events: write. Co-authored-by: Jared Wray <me@jaredwray.com>
The workflows set HYPHEN_PUBLIC_API_KEY and HYPHEN_APPLICATION_ID. Source files do not read those variables. Tests use literal values. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the security and configuration documentation, expands the Biome linter configuration, and refactors the package cleanup script. Specifically, DEFENSE_IN_DEPTH.md and SECURITY.md are updated to reflect the pinning of pnpm@12.17.0, clarify that Aikido scans run only on release workflows rather than pull requests, and document that the zizmor job grants security-events: write permissions. Additionally, biome.json is updated to include .tsx files in src and test directories, and the clean script in package.json is modified to prevent the deletion of pnpm-lock.yaml. There are no review comments to address, and no further feedback is provided.
Sort the imports in the .tsx files. Put the Biome includes list on one line. Remove the unused effect dependency. Use an arrow function for the generic wrapper. Move test components to module scope. Co-authored-by: Jared Wray <me@jaredwray.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #99 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 19 18 -1
Branches 1 1
=========================================
- Hits 19 18 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Configuration fix and docs update.
Summary
Biome includes now cover
.tsxfiles insrcandtest.The clean script keeps
pnpm-lock.yaml.SECURITY.mdandDEFENSE_IN_DEPTH.mdmatchpnpm@12.17.0and the release scan.The three workflows do not set
HYPHEN_PUBLIC_API_KEYorHYPHEN_APPLICATION_ID.The
.tsxfiles now passbiome check --error-on-warnings.Test audit
This pull request does not add a test.
This pull request does not delete a test.
test/toggle-provider.test.tsx,test/use-toggle.test.tsx, andtest/with-toggle-provider.test.tsxchanged so Biome can check them.The assertions stay the same.
The components now live at module scope.
noComponentHookFactoriesrejects a component inside a test function.No new export is required.
Checks
Biome 2.6.4
check --write --error-on-warningsexited 0.Python parsed
biome.jsonandpackage.json.Python parsed
tests.yaml,code-coverage.yaml, andrelease.yaml.Local
pnpm installdid not finish. The Safe Chain tunnel refused connections.This environment has no Aikido scan server.
Run
/aikido:setupbefore you rely on a scan of these files.