Repository navigation
fix: security - update certifi to 2026.10.23 (emSign ECC Root CA) - #11
Conversation
Remove the compromised emSign ECC Root CA - G3 from the locked CA bundle (PYSEC-2026-4320 / GHSA-6q48-6c7w-9gw2). Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the certifi package version in poetry.lock to 2026.10.23. The reviewer recommends adding a direct dependency floor for certifi >= 2026.10.19 in pyproject.toml to ensure downstream consumers are also protected from the compromised emSign intermediate CA.
| [[package]] | ||
| name = "certifi" | ||
| version = "2025.1.31" | ||
| version = "2026.10.23" |
There was a problem hiding this comment.
While updating certifi in poetry.lock secures the local development and CI environments, downstream consumers of this library will still resolve certifi based on their own lock files or other dependencies (since requests only requires certifi>=2017.4.17). To ensure downstream users are not exposed to the compromised emSign intermediate CA, consider adding a direct dependency floor for certifi >= 2026.10.19 in pyproject.toml under [tool.poetry.dependencies].
Summary
Updates the locked
certifiCA bundle so this package's dev and CI environments no longer trust the compromised emSign intermediate CA.hyphen_clientcalls the Hyphen API over HTTPS withrequests, which uses this bundle.certifibefore 2026.10.18 shipped the "emSign ECC Root CA - G3" root whose subordinate CA keys were compromised, so an on-path attacker could forge TLS certificates trusted by requests, urllib3, and pip. 2026.10.18 removed every emSign root; 2026.10.19 restored the unaffected ones. 2026.10.23 is the latest release on PyPI (published 2026-10-23). The updated bundle still contains the unaffected "emSign Root CA - G1" and does not contain "emSign ECC Root CA - G3".Only
poetry.lockchanged.poetry update certifidid not move any other package. Runtime ranges inpyproject.tomlare unchanged;requestsalready allowscertifi>=2017.4.17.Suggestion: add a direct
certifi>=2026.10.19dependency floor if downstream installs should be forced onto a fixed bundle. That floor was not added in this change.Other trust-store surfaces
Nothing else in the repo needed a change:
REQUESTS_CA_BUNDLEorSSL_CERT_FILEsettings.actions/setup-python@v5with Python 3.11. That action does not pin a CA bundle. Afterpoetry install,requestsuses the lockedcertifibundle.Release
There is no pnpm cooldown in this repo (Python/Poetry). Downstream consumers resolve their own
certifi, so a release is optional unless a dependency floor is added.The Release workflow on
mainruns python-semantic-release withupload_to_pypi = true. Squash-merging afix:title would publish a patch. Needs Jared's sign-off before merge if that publish should not happen.Test plan
poetry install --no-interactionpoetry run ruff check .poetry run pytest(28 passed)