Skip to content

fix: security - update certifi to 2026.10.23 (emSign ECC Root CA) - #11

Merged
jaredwray merged 1 commit into
mainfrom
cursor/certifi-emsign-ca-c104
Oct 30, 2026
Merged

jaredwray merged 1 commit into
mainfrom
cursor/certifi-emsign-ca-c104

Conversation

@jaredwray

Copy link
Copy Markdown
Contributor

Summary

Updates the locked certifi CA bundle so this package's dev and CI environments no longer trust the compromised emSign intermediate CA. hyphen_client calls the Hyphen API over HTTPS with requests, which uses this bundle.

Package Old New Advisory
certifi 2025.1.31 2026.10.23 PYSEC-2026-4320 / GHSA-6q48-6c7w-9gw2 (aliases CVE-2026-111943 / CVE-2026-91403)

certifi before 2026.10.18 shipped the "emSign ECC Root CA - G3" root whose subordinate CA keys were compromised, so an on-path attacker could forge TLS certificates trusted by requests, urllib3, and pip. 2026.10.18 removed every emSign root; 2026.10.19 restored the unaffected ones. 2026.10.23 is the latest release on PyPI (published 2026-10-23). The updated bundle still contains the unaffected "emSign Root CA - G1" and does not contain "emSign ECC Root CA - G3".

Only poetry.lock changed. poetry update certifi did not move any other package. Runtime ranges in pyproject.toml are unchanged; requests already allows certifi>=2017.4.17.

Suggestion: add a direct certifi>=2026.10.19 dependency floor if downstream installs should be forced onto a fixed bundle. That floor was not added in this change.

Other trust-store surfaces

Nothing else in the repo needed a change:

  • No Dockerfiles or base images.
  • No custom CA bundles.
  • No REQUESTS_CA_BUNDLE or SSL_CERT_FILE settings.
  • GitHub Actions uses actions/setup-python@v5 with Python 3.11. That action does not pin a CA bundle. After poetry install, requests uses the locked certifi bundle.

Release

There is no pnpm cooldown in this repo (Python/Poetry). Downstream consumers resolve their own certifi, so a release is optional unless a dependency floor is added.

The Release workflow on main runs python-semantic-release with upload_to_pypi = true. Squash-merging a fix: title would publish a patch. Needs Jared's sign-off before merge if that publish should not happen.

Test plan

  • poetry install --no-interaction
  • poetry run ruff check .
  • poetry run pytest (28 passed)
Open in Web Open in Cursor 

Remove the compromised emSign ECC Root CA - G3 from the locked CA
bundle (PYSEC-2026-4320 / GHSA-6q48-6c7w-9gw2).

Co-authored-by: Jared Wray <me@jaredwray.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-30T14:33:55.140515Z 399c05e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the certifi package version in poetry.lock to 2026.10.23. The reviewer recommends adding a direct dependency floor for certifi >= 2026.10.19 in pyproject.toml to ensure downstream consumers are also protected from the compromised emSign intermediate CA.

Comment thread poetry.lock
[[package]]
name = "certifi"
version = "2025.1.31"
version = "2026.10.23"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-medium medium

While updating certifi in poetry.lock secures the local development and CI environments, downstream consumers of this library will still resolve certifi based on their own lock files or other dependencies (since requests only requires certifi>=2017.4.17). To ensure downstream users are not exposed to the compromised emSign intermediate CA, consider adding a direct dependency floor for certifi >= 2026.10.19 in pyproject.toml under [tool.poetry.dependencies].

@jaredwray
jaredwray merged commit 140f55f into main Oct 30, 2026
4 checks passed
@jaredwray
jaredwray deleted the cursor/certifi-emsign-ca-c104 branch October 30, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants