Skip to content

mono - chore: remove undici-types override - #5

Merged
jaredwray merged 1 commit into
mainfrom
chore/override-undici-types
Nov 17, 2026
Merged

jaredwray merged 1 commit into
mainfrom
chore/override-undici-types

Conversation

@jaredwray

Copy link
Copy Markdown
Contributor

Summary

The undici-types@6.21.0 override is gone. No package requests undici-types@6.21.0 after @types/node moved to 24.19.2. The install still resolves undici-types@7.24.6.

Changes

  • Delete the undici-types@6.21.0 pin from pnpm-workspace.yaml.
  • Drop the unused @napi-rs/wasm-runtime@1.1.6 snapshot. The optional binding now uses 1.2.6, which was already in the lockfile.

Artifact diffs

Verification

  • pnpm install passes
  • pnpm build passes
  • pnpm peers check reports no issues
  • pnpm --filter @hyphen/react-sdk test passes
  • The Node.js SDK tests and the browser evaluation tests need the CI secrets. This environment has no API keys.

Test audit

This pull request does not add, change, or delete a test.

Open in Web Open in Cursor 

No package requests undici-types 6.21.0 after the Node types move to 24.

Co-authored-by: Jared Wray <me@jaredwray.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T20:49:07.832404Z 31c0ed7 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Nov 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (35200be) to head (31c0ed7).

Additional details and impacted files
@@            Coverage Diff            @@
##              main        #5   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          824       824           
  Branches       194       194           
=========================================
  Hits           824       824           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jaredwray
jaredwray merged commit 93ef05a into main Nov 17, 2026
10 checks passed
@jaredwray
jaredwray deleted the chore/override-undici-types branch November 17, 2026 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants