Repository navigation
mono - chore: upgrade code quality dependencies - #3
Merged
Merged
Conversation
Move Biome to 2.6.6 and Vitest to 5.1.0. Rename duplicate test titles for the new Biome rule. Co-authored-by: Jared Wray <me@jaredwray.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 824 824
Branches 194 194
=========================================
Hits 824 824 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Biome is now 2.6.6 and Vitest is now 5.1.0 in each SDK. These are the newest versions that pass the 7-day gate.
Changes
@biomejs/biome,vitest, and@vitest/coverage-v8.env()tests unique titles.Artifact diffs
Verification
pnpm buildpassesbiome check --error-on-warningspasses in@hyphen/sdkpnpm --filter @hyphen/react-sdk testpassesTest audit
env()tests inpackages/nodejs-sdk/test/env.test.tshave new titles. The assertions stay the same. Biome 2.6.6 rejects a duplicate title.should emit toggle info eventstest inpackages/nodejs-sdk/test/hyphen.test.tsis deleted. The earlier test with that title proves the same contract.