Repository navigation
XMLHttpRequest: return the parsed json response on its first read - #523
Draft
wesgarland wants to merge 1 commit into
Draft
wesgarland wants to merge 1 commit into
wesgarland wants to merge 1 commit into
Conversation
get response() parsed and cached a json response, then fell through to the unsupported-responseType throw; only later reads, served from the cache, returned it.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
get response()withresponseType = 'json'parsed and cached the body, then fell through to the "unsupported responseType" throw: the first read threw, later reads returned the cached object. Adds the missingreturn.Found through dcp-client, whose
jnu.connect()reads a json response once and so failed under PythonMonkey.tests/python/test_xhr.pygains aresponseType = 'json'case: it fails on 1.5.1 and passes with this change.