Skip to content

setup.sh: idempotent patch seds; xhr-http-keep-alive test: clear strace failure - #519

Open
wesgarland wants to merge 2 commits into
mainfrom
wes/fix/setup-sh-rerun-and-strace-check
Open

wesgarland wants to merge 2 commits into
mainfrom
wes/fix/setup-sh-rerun-and-strace-check

Conversation

@wesgarland

Copy link
Copy Markdown
Collaborator
  • setup.sh: make the Unbox and -ld64 patch seds idempotent so a re-run does not double-patch
  • xhr-http-keep-alive test: fail clearly when strace is missing or cannot trace, instead of reporting 0 connections

…be re-run

The Unbox and -ld64 substitutions matched their own output, so a second run produced
JS_PUBLIC_API JS_PUBLIC_API and a nested -ld64 expression. Skip lines already patched.
…not trace

Previously a missing strace was reported as "TCP connections opened: 0".
@wesgarland
wesgarland marked this pull request as ready for review November 18, 2026 13:54
@wesgarland
wesgarland requested a review from Xmader November 18, 2026 13:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant