Repository navigation
setup.sh: idempotent patch seds; xhr-http-keep-alive test: clear strace failure - #519
Open
wesgarland wants to merge 2 commits into
Open
wesgarland wants to merge 2 commits into
wesgarland wants to merge 2 commits into
Conversation
wesgarland
commented
Nov 18, 2026
Collaborator
- setup.sh: make the Unbox and -ld64 patch seds idempotent so a re-run does not double-patch
- xhr-http-keep-alive test: fail clearly when strace is missing or cannot trace, instead of reporting 0 connections
…be re-run The Unbox and -ld64 substitutions matched their own output, so a second run produced JS_PUBLIC_API JS_PUBLIC_API and a nested -ld64 expression. Skip lines already patched.
…not trace Previously a missing strace was reported as "TCP connections opened: 0".
wesgarland
marked this pull request as ready for review
November 18, 2026 13:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.