Skip to content

chore: bump pinned valgrind-codspeed to 3.26.0-0codspeed14 - #626

Merged
adriencaccia merged 1 commit into
mainfrom
cod-4234-release-valgrind-codspeed-3260-0codspeed14-and-bump
Nov 14, 2026
Merged

adriencaccia merged 1 commit into
mainfrom
cod-4234-release-valgrind-codspeed-3260-0codspeed14-and-bump

Conversation

@adriencaccia

Copy link
Copy Markdown
Member

Bump the pinned valgrind-codspeed to 3.26.0-0codspeed14, which adds Callgrind's --rep-bulk-cost option (CodSpeedHQ/valgrind-codspeed#60). --experimental-rep-bulk-cost (#620) already passes that option, and 0codspeed13 rejects it as unknown.

Case Before Now
Simulation run without the flag 0codspeed13 0codspeed14, same results (the option is off by default)
--experimental-rep-bulk-cost with --cycle-estimation Callgrind rejects --rep-bulk-cost=yes, the run fails amd64 rep movs/rep stos priced from the bulk cost curves

The 6 hashes match both the release asset digests and a local shasum -a 256 of each .deb.

Closes COD-4234

`--experimental-rep-bulk-cost` passes `--rep-bulk-cost=yes` to
Callgrind, which 0codspeed13 rejects as an unknown option, so the run
fails. 0codspeed14 adds the option (CodSpeedHQ/valgrind-codspeed#60),
off by default: results without the flag do not change.

Closes COD-4234
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codspeed

codspeed Bot commented Nov 14, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

2 warnings

⚠️ Walltime results may be unreliable

Some benchmarks used the Walltime instrument outside CodSpeed Macro Runners, which can make the results inconsistent.

Learn more about Macro Runners

See affected benchmarks

⚠️ 8 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

✅ 53 untouched benchmarks
⏩ 6 skipped benchmarks1


Comparing cod-4234-release-valgrind-codspeed-3260-0codspeed14-and-bump (602d5ea) with main (9589414)

Open in CodSpeed

Footnotes

  1. 6 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@adriencaccia
adriencaccia marked this pull request as ready for review November 14, 2026 01:01
@greptile-apps

greptile-apps Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Updates the pinned Valgrind release from 3.26.0-0codspeed13 to 3.26.0-0codspeed14.

  • Linux simulation runs now use Valgrind 0codspeed14.

Reviews (1) · Last reviewed commit: "chore: bump pinned valgrind-codspeed to ..." · Reviewed by Greptile

@adriencaccia
adriencaccia merged commit 2cc0728 into main Nov 14, 2026
68 checks passed
@adriencaccia
adriencaccia deleted the cod-4234-release-valgrind-codspeed-3260-0codspeed14-and-bump branch November 14, 2026 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant