Skip to content

[PWGCF] LambdaProtonBalanceFunction-Errors has been reduced and calculations redefined-Edit14 - #18815

Merged
wenyaCern merged 4 commits into
AliceO2Group:masterfrom
Anoop1379:master
Nov 19, 2026
Merged

wenyaCern merged 4 commits into
AliceO2Group:masterfrom
Anoop1379:master

Conversation

@Anoop1379

Copy link
Copy Markdown
Contributor

Edited for error reduction.

Edited for error reduction.
@github-actions github-actions Bot added the pwgcf label Nov 19, 2026
@github-actions github-actions Bot changed the title LambdaProtonBalanceFunction-Errors has been reduced and calculations redefined-Edit14 [PWGCF] LambdaProtonBalanceFunction-Errors has been reduced and calculations redefined-Edit14 Nov 19, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 157 warnings, 🔕 0 disabled

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 006b399 at 2026-11-19 11:44:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 4 errors and 6 warnings.'
Found 4 errors and 6 warnings.
++ [[ 4 -gt 0 ]]
++ cat /sw/BUILD/d1643873c38040065782f839f9c83400e0b47c34/O2Physics-code-check/errors.txt
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:506:17: error: no header providing "std::hexfloat" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:756:60: error: string concatenation results in allocation of unnecessary temporary strings; consider using 'operator+=' or 'string::append()' instead [performance-inefficient-string-concatenation,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:776:51: error: do not use static_cast to downcast from a base to a derived class; use dynamic_cast instead [cppcoreguidelines-pro-type-static-cast-downcast,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:3704:38: error: std::move of the variable 'particle' of the trivially-copyable type 'CombinedParticle' has no effect [performance-move-const-arg,-warnings-as-errors]
++ [[ 6 -gt 0 ]]
++ cat /sw/BUILD/d1643873c38040065782f839f9c83400e0b47c34/O2Physics-code-check/warnings.txt
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:634:11: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:722:26: warning: implicit conversion 'unsigned int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:756:14: warning: implicit conversion 'TH3D *' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:824:31: warning: implicit conversion 'bool' -> 'int' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:3514:13: warning: implicit conversion 'unsigned int' -> 'bool' [readability-implicit-bool-conversion]
PWGCF/TwoParticleCorrelations/Tasks/lambdaProtonBalanceFunction.cxx:3671:92: warning: repeated branch body in conditional chain [bugprone-branch-clone]
++ [[ 4 -gt 0 ]]
++ exit 1
--

Full log here.

@wenyaCern
wenyaCern merged commit 16a849c into AliceO2Group:master Nov 19, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants