Skip to content

[PWGDQ] Add DsToKKPi process in Dilepton-Track task - #18729

Open
larsfop wants to merge 7 commits into
AliceO2Group:masterfrom
larsfop:master
Open

larsfop wants to merge 7 commits into
AliceO2Group:masterfrom
larsfop:master

Conversation

@larsfop

@larsfop larsfop commented Nov 13, 2026

Copy link
Copy Markdown

No description provided.

@github-actions github-actions Bot added the pwgdq label Nov 13, 2026
@github-actions

github-actions Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 750 warnings, 🔕 1 disabled

Comment thread PWGDQ/Tasks/tableReader_withAssoc.h Resolved
iarsene
iarsene previously approved these changes Nov 16, 2026
iarsene
iarsene previously approved these changes Nov 18, 2026
@iarsene
iarsene enabled auto-merge (squash) November 18, 2026 19:54
@alibuild

alibuild commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 99998a6 at 2026-11-19 01:07:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 99998a6 at 2026-11-19 01:52:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Nov 18, 2026 •

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 99998a6 at 2026-11-19 03:19:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 3 errors and 12 warnings.'
Found 3 errors and 12 warnings.
++ [[ 3 -gt 0 ]]
++ cat /sw/BUILD/0b1c23392f7b7a7cf125daad7536770c064cffe7/O2Physics-code-check/errors.txt
PWGDQ/Tasks/tableReader_withAssoc.h:354:86: error: no header providing "o2::constants::lhc::LHCRevFreq" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: Value stored to 'isDsToKKPi' during its initialization is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGDQ/Tasks/tableReader_withAssoc.h:4254:10: error: unused variable 'isDsToKKPi' [clang-diagnostic-unused-variable,-warnings-as-errors]
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/0b1c23392f7b7a7cf125daad7536770c064cffe7/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.h:1272:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1273:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1689:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1693:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3504:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3505:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4773:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5506:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5509:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5510:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7313:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Tasks/tableReader_withAssoc.h:4988:36: warning: initializer for member 'fDileptonCut' is redundant [readability-redundant-member-init]
++ [[ 3 -gt 0 ]]
++ exit 1
--

Full log here.

auto-merge was automatically disabled November 19, 2026 09:59

Head branch was pushed to by a user without write access

@vkucera

vkucera commented Nov 19, 2026 •

Copy link
Copy Markdown
Collaborator

@iarsene Please do not enable auto-merge before the checks finish. If you do, any errors found by the linters will get merged.

@iarsene

iarsene commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

@iarsene Please do not enable auto-merge before the checks finish. If you do, any errors found by the linters will get merged.

The lint errors happening now are not related to this PR. @axti98 is currently working to fix them

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 38d256f at 2026-11-19 11:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'To reproduce the results below locally, run: '\''aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'\''.'
To reproduce the results below locally, run: 'aliBuild build O2Physics-code-check -e ALIBUILD_BASE_HASH=upstream/master'.
++ echo 'To apply all automatic fixes, add the '\''-e O2PHYSICS_CHECKER_FIX=1'\'' option.'
To apply all automatic fixes, add the '-e O2PHYSICS_CHECKER_FIX=1' option.
++ echo 'See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.'
See the documentation for more details at: <https://aliceo2group.github.io/analysis-framework/docs/tools/#running-with-o2physics-code-check>.
++ echo 'Found 1 errors and 12 warnings.'
Found 1 errors and 12 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/d98be40f85e8d71899864171e011f038ea5a172a/O2Physics-code-check/errors.txt
PWGDQ/Tasks/tableReader_withAssoc.h:356:86: error: no header providing "o2::constants::lhc::LHCRevFreq" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 12 -gt 0 ]]
++ cat /sw/BUILD/d98be40f85e8d71899864171e011f038ea5a172a/O2Physics-code-check/warnings.txt
PWGDQ/Core/VarManager.h:1273:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1274:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1690:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:1694:10: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:3505:11: warning: variable 'dcaX' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:3506:11: warning: variable 'dcaY' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Core/VarManager.h:4774:14: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5516:7: warning: do not declare C-style arrays, use 'std::array' instead [modernize-avoid-c-arrays]
PWGDQ/Core/VarManager.h:5519:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:5520:33: warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
PWGDQ/Core/VarManager.h:7323:9: warning: variable 'pairPhiV' is not initialized [cppcoreguidelines-init-variables]
PWGDQ/Tasks/tableReader_withAssoc.h:5082:36: warning: initializer for member 'fDileptonCut' is redundant [readability-redundant-member-init]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@vkucera

vkucera commented Nov 19, 2026

Copy link
Copy Markdown
Collaborator

@iarsene Please do not enable auto-merge before the checks finish. If you do, any errors found by the linters will get merged.

The lint errors happening now are not related to this PR. @axti98 is currently working to fix them

OK, fair enough. Thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

4 participants